Directory case issue

[johnd]

Sorry in advance about the length of this:

I don't use the gallery feature often myself, but in the process of writing the docs I tend to try everything to see how it works. When I tried the gallery feature, I got nothing but the "cover missing" image. Clicking on a "cover missing" image showed the correct full cover image. Looked in the "Thumbnails" directory on the server. Everything was there as expected. Noticed that the directory on the server was called "Thumbnails", with a capital "T". Changed it to "thumbnails" and the gallery now showed the correct set of images.

Ran the rsync script. "thumbnails" directory was removed and replaced with a "Thumbnails" directory!

The problem is that the install of DVDProfiler, or creation of a new database, creates a directory called "Images", and a subdirectory called "Thumbnails". Note the capitalisation. Since rsync creates an exact copy of the DVDProfiler "Images" directory, it creates the thumbnail directory as "Thumbnails", or removes the "thumbnails" directory and recreates it as "Thumbnails". Looking at the gallery script shows that it requires the directory to be called "thumbnails".

The obvious fix is to rename the DVDProfiler directory from "Thumbnails" to "thumbnails". This does not affect DVDProfiler, as Windows cares not a jot about case, but is hardly an elegant solution.

Suggestions?

[SH84]

I'll add a variable for the directory name...
Until then, you could edit the gallery.php (lines 114 & 117).

[fredlooks]

It isn't just the gallery, 'thumbnails' with lower-case 't' is hard-coded in many places. It just falls back to scaled images in other places. This tends to make the tumbs displayed look poor. I'll add a variable that can be set to the name of the thumbs directory....

[ajm]

As loads of places will need changing to use the new variable for the thumbnails directory, you could make it try and find the directory automatically instead.

The bigger job is changing the 1000's of references however. Could be a project in itself

[fredlooks]

Not really. grep thumbnails *.php|wc -l returns 46 lines, and at least 11 of them are comments ... the only files affected are functions.php, gallery.php, index.php, imagedata.php and the old getimages.php.

Not as bad as I thought at all ...

[ajm]

I'm shocked ws.php isn't in the list. Although, its code probably just got moved to functions.php.

[fredlooks]

Yup. all the references to thumbnails in ws.php were in resize_jpeg() which got moved to functions.php